[styles] Fix issues reported by eslint-plugin-react-compiler #43118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Netlify deploy previewhttps://deploy-preview-43118--material-ui.netlify.app/ Bundle size report |
zannager
added
core
66 tasks
aarongarciah
changed the title
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com> Signed-off-by: jlewins <142214262+jlewins@users.noreply.github.com>
aarongarciah
force-pushed
the
eslint-mui-docs
branch
from
47cd89c
to
4210f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42564
FILES CHANGED:
StylesProvider.js: ESLint error: "Unexpected reassignment of a variable which was defined outside of the component. Components and hooks should be pure and side-effect free, but variable reassignment is a form of side-effect." Line 87. Moved variable definition of 'injectFirstNode' inside of 'StylesProvider' function, fixing ESLint error
makeStyles.js: ESLint error: "Expected the dependency list for useMemo to be an array literal" Line 167. Changed 'useMemo' param "values" to "[values]", fixing ESLint error
makeStyles.spec.tsx: ESLint error: "Hooks must be the same function on every render but this value may change over time to a different function." Line 132. Moved definition of 'useStyles' outside of function 'PartialTypeInferenceTest' to align with rules of hooks, fixing ESlint error
withStyles.js: ESLint error: "React Compiler has skipped optimizing this component because one or more React ESLint rules were disabled. React Compiler only works when your components follow all the rules of React, disabling them may result in unexpected or incorrect behavior" Line 60. Unsure of common practice for this error, and was unable to find other examples in repo so fixed via silencing for now but advice would be appreciated.